[SofaKernel] SofaComponentCommon does not always register all its components in the object factory #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For some reason, I stumbled upon a strange error where
EulerImplicitSolver
is no longer registered in the factory. It turns out that someinit...()
methods call are missing inSofaComponentCommon
Maybe this error arised on master because some includes directive have been cleaned, or some
dependencies have been removed which were hiding this problem before.
CHANGELOG
FIX
[SofaComponentCommon]
initComponentCommon()
method calls the init method of all the libraries that compose the package so that we are sure theObjectFactory
is well populated.This PR:
Reviewers will merge only if all these checks are true.