Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaPhysicsAPI] FIX: compilation due to Sofa main API changes #549

Merged
merged 1 commit into from
Jan 5, 2018
Merged

[SofaPhysicsAPI] FIX: compilation due to Sofa main API changes #549

merged 1 commit into from
Jan 5, 2018

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jan 2, 2018 •
edited by guparan
Loading

Small PR to fix SofaPhysicsAPI compilation broken due to changes done in sofa main API on:

  • helper::io::Image
  • GUIManager::RegisterGUI

Maybe this project should be added to one of the vm of the dashboard?

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added the pr: fix Fix a bug label Jan 2, 2018
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Jan 3, 2018
@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 3, 2018
@sofa-framework sofa-framework deleted a comment from sofabot Jan 3, 2018
@damienmarchal
Copy link
Contributor

[ci-build]

@guparan guparan merged commit eb91067 into sofa-framework:master Jan 5, 2018
@guparan guparan added this to the v17.12 milestone Jan 10, 2018
damienmarchal added a commit to SofaDefrost/sofa that referenced this pull request Jan 18, 2018
@damienmarchal
[plugins/MultiThreading] FIX problem at initialization of mTaskMutex.v_
eebbd39 
The plugin is broken since PR sofa-framework#549 as it removes the initialization
of the mutex. Possible explaination is that v_ is implementation
dependent but the existing initialization was done incorrectly
using a (int).

Now use BOOST_DETAIL_SPINLOCK_INIT which insure that the initialization
is coherent with the implementation used.

(I also cannot prevent myself to remove the two ugly commented lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@epernod @damienmarchal @guparan @hugtalbot