Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseLinearSolver] Improve warning emission for CG #658

Merged
merged 2 commits into from
May 24, 2018
Merged

[SofaBaseLinearSolver] Improve warning emission for CG #658

merged 2 commits into from
May 24, 2018

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented May 16, 2018 •
edited by guparan
Loading

CG was emitting inappropriate warnings regarding threshold-tolerance.

This PR fixes it by checking if this is the first time step and first iteration.
This PR also checks the cases with division by zero.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

hugtalbot added 2 commits May 16, 2018 17:28
@hugtalbot
[SofaBaseLinearSolver] Improve warning emission for CG
e2a05b0 
CG was emitting unappropriate warnings regarding threshold-tolerance.
This PR fixes it by checking if this is the first time step and
first iteration.
This PR also checks the cases with division by zero.
@hugtalbot
ADD another minor check
107e93a 
Add another minor check for validity of threshold in case
where norm of b is null.
@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels May 16, 2018
@hugtalbot hugtalbot added this to the v18.06 milestone May 16, 2018
@hugtalbot hugtalbot requested a review from epernod May 16, 2018 16:39
@hugtalbot
Copy link
Contributor Author

[ci-build][with-scene-tests]

@hugtalbot
Copy link
Contributor Author

I really don't see the link of the two new crashes on Max / Linux :

  • optiTrack : with a crash from a libc++abi
libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl
  • a CPU scene with beams in SofaCUDA plugin with a strange timeout (that I can't reproduce locally)

Does anyone has a clue?
[ci-build][with-scene-tests]

@hugtalbot
Copy link
Contributor Author

[ci-build][with-scene-tests]

@guparan guparan merged commit ab70766 into sofa-framework:master May 24, 2018
@hugtalbot hugtalbot deleted the improve_cg_warnings branch September 21, 2018 16:40
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees

@guparan guparan

Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @epernod @guparan