Skip to content

[SofaBaseLinearSolver] Add ability to activate printing of debug information at runtime #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2018

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented May 25, 2018

Here is a very simple implementation that enable extra printing to help in understanding why some scenes are failing/crashing.

I also add few scenes with single solvers because those components where not tested anywhere in our CI.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels May 25, 2018
@damienmarchal
Copy link
Contributor Author

[ci-build][with-scene-tests]

@damienmarchal
Copy link
Contributor Author

damienmarchal commented May 30, 2018

@hugtalbot I was not able to reproduce the scene crash on my pc.
I will remove the scene :)

@tgaugry
Copy link
Contributor

tgaugry commented Jun 13, 2018

Seems fine for me 👍

@damienmarchal
Copy link
Contributor Author

@guparan, @hugtalbot Could we considering merging those...they are now wainting since weeks :)

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 26, 2018
@damienmarchal
Copy link
Contributor Author

[ci-build][with-scene-tests]

1 similar comment
@guparan
Copy link
Contributor

guparan commented Jun 29, 2018

[ci-build][with-scene-tests]

@epernod
Copy link
Contributor

epernod commented Jul 10, 2018

[ci-build][with-scene-tests]

@guparan guparan merged commit 579e748 into sofa-framework:master Jul 10, 2018
@guparan guparan added this to the v18.06 milestone Jul 12, 2018
@damienmarchal damienmarchal deleted the Sofa_addDoPrintMatrix branch August 6, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants