Clean version of Gaurab PR #639 : Unifying the way we report file related errors #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[ci-build][with-scene-tests] |
epernod
added
enhancement
| @@ -130,7 +130,7 @@ | |||
|
|
|||
| #define FILEINFO(filename, line) sofa::helper::logging::FileInfo(filename, line) | |||
|
|
|||
| #define FILEINFO(filename, line) sofa::helper::logging::FileInfo(filename, line) | |||
| #define FILEINFO(filename, line) sofa::helper::logging::FileInfo(filename, line) //rewritten again. delete this? | |||
There was a problem hiding this comment.
done in last commit ee41312
| @@ -54,13 +55,12 @@ void MeshTrian::init (std::string filename) | |||
| return; | |||
| } | |||
| FILE *f = fopen(filename.c_str(), "r"); | |||
| msg_error_when(!f)<<sofa::helper::messaging::FileMessage::UnableToOpenFile(filename.c_str()); | |||
There was a problem hiding this comment.
done in last commit ee41312
…And remove duplicated define.
guparan
approved these changes
May 30, 2018
guparan
added
pr: status ready
6 tasks
|
This one is a small PR so maybe we can merge it before the 7 days ? |
|
I would say yes as it is the clean version of a 3 weeks old PR. |
guparan
added
the
pr: fast merge
|
I had been into competitive programming these days and also busy with a small project of mine. Thanks @epernod for making good use of my work. 😄 |
|
you are welcome. Thanks for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Gaurab seems to be unreachable those days. As I want to use his good work, here is a quick cherry pick of his PR #639
This PR:
Reviewers will merge only if all these checks are true.