New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGeneralEngine] FIX disabled tests #675

Merged

hugtalbot merged 1 commit into sofa-framework:master from guparan:fix_sofageneralenginetest

Jun 6, 2018

Contributor

guparan commented Jun 4, 2018 •

edited

Loading

I forgot one file in #586, leading to the disappearance of 14 tests.

You didn't see it? Me neither.

This PR:

builds with SUCCESS for all platforms on the CI.
does not generate new warnings.
does not generate new unit test failures.
does not generate new scene test failures.
does not break API compatibility.
is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.


          [SofaGeneralEngine] FIX disabled tests

a4145fb

guparan added location: tests pr: fix pr: fast merge pr: status to review pr: status ready and removed pr: status to review labels

hugtalbot merged commit 5df837f into sofa-framework:master

guparan added this to the v18.06 milestone

guparan deleted the fix_sofageneralenginetest branch

October 1, 2018 14:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge pr: fix pr: status ready