Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix byte array class name #6

Merged
merged 1 commit into from
Nov 21, 2018
Merged

fix: fix byte array class name #6

merged 1 commit into from
Nov 21, 2018

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Nov 21, 2018 •
edited by gxcsoccer
Loading

This change is Reviewable

@killagu killagu added the bug Something isn't working label Nov 21, 2018
@killagu killagu requested a review from gxcsoccer November 21, 2018 09:12
gxcsoccer
gxcsoccer approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@gxcsoccer gxcsoccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gxcsoccer gxcsoccer merged commit 40c9467 into master Nov 21, 2018
@codecov
Copy link

codecov bot commented Nov 21, 2018 •
edited
Loading

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #6   +/-   ##
======================================
  Coverage    96.2%   96.2%           
======================================
  Files          29      29           
  Lines         738     738           
======================================
  Hits          710     710           
  Misses         28      28
Impacted Files Coverage Δ
lib/utils.js 98.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a2362...51b4679. Read the comment docs.

@gxcsoccer gxcsoccer deleted the byte-array branch November 21, 2018 09:17
@gxcsoccer
Copy link
Member

1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxcsoccer gxcsoccer gxcsoccer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killagu @gxcsoccer