-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recorder support #351
Add recorder support #351
Conversation
WalkthroughThis update brings enhancements to a Java project by upgrading dependencies in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- pom.xml (2 hunks)
- src/main/java/com/alipay/remoting/InvokeContext.java (3 hunks)
- src/main/java/com/alipay/remoting/rpc/protocol/RpcRequestProcessor.java (2 hunks)
Files skipped from review due to trivial changes (1)
- pom.xml
Additional comments not posted (7)
src/main/java/com/alipay/remoting/InvokeContext.java (5)
19-19
: Import ofRecordContext
correctly added for use in insight recording.
76-76
: FieldrecordContext
correctly declared for managing recording context.
85-85
: Initialization ofrecordContext
in the constructor ensures that it is ready for use immediately upon object creation.
137-137
: ResettingrecordContext
in theclear
method ensures that the recording context is properly cleared when needed.
146-148
: ThegetRecordContext
method is correctly implemented to provide access to therecordContext
.src/main/java/com/alipay/remoting/rpc/protocol/RpcRequestProcessor.java (2)
23-25
: Import statements for recording functionality correctly added to support the new features.
137-156
: The recording functionality is correctly wrapped around the existing logic in thedoProcess
method, ensuring that recording starts before processing and stops in thefinally
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* feat: add recorder support * upgrade version to 1.6.10 --------- Co-authored-by: jingmu <muqing.muqingcai@antgroup.com>
Summary by CodeRabbit