Upgrade rpc all version to 5.13.2 #1356
Conversation
WalkthroughThis pull request includes an update to the version of the Changes
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)sofa-boot-project/sofa-boot-autoconfigure/src/main/java/com/alipay/sofa/boot/autoconfigure/rpc/SofaRpcAutoConfiguration.java (1)
This refactor successfully removes the extra temporary variable and directly returns a new instance of SofaBootRpcStartListener. It keeps the logic straightforward. To confirm there are no lingering references to the removed property (e.g., 'lookoutCollectDisable'), run the following script to identify any code still referencing it: ✅ Verification successfulLet me search for any usage of this property in the configuration or other parts of the codebase to ensure it's safe to remove. Let me check if this property is used in any configuration classes or if there are any references to it in the RPC configuration setup. Let me check one final thing - if this property is used in any of the RPC configuration or listener classes. The refactoring to return a new instance directly is safe and approved. Based on the verification results:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for references to 'lookoutCollectDisable' or any associated methods in the codebase.
rg 'lookoutCollectDisable' -A 3 -B 3
Length of output: 2923 Script: #!/bin/bash
# Search for any usage of getLookoutCollectDisable() method or references to lookout collect configuration
rg -i "lookout.*collect|getlookoutcollect" -A 3 -B 3
# Also check for any configuration properties files that might reference this
fd -e properties -e yaml -e yml --exec grep -l -i "lookout.*collect|lookout.*disable" {} \;
Length of output: 3208 Script: #!/bin/bash
# Search for any usage of the property in configuration classes
ast-grep --pattern 'getLookoutCollectDisable()'
# Search for any references to this property in RPC configuration
rg -l "com.alipay.sofa.rpc" | xargs rg -i "lookout" -A 3 -B 3
Length of output: 3454 Script: #!/bin/bash
# Search for any usage in RPC configuration classes and listeners
rg -l "SofaBootRpcStartListener|RpcConfig" | xargs rg -i "lookout" -A 3 -B 3
# Also check for any Spring configuration properties that might reference this
fd -e properties -e yaml -e yml --exec grep -l -i "com.alipay.sofa.rpc.lookout" {} \;
Length of output: 165 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: JermaineHua <crazyhzm@apache.org>
CrazyHZM
force-pushed
the
4.x_feat/upgrade_rpc_version
branch
from
a9b1515 to
2190052
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1356 +/- ##
============================================
- Coverage 82.92% 82.91% -0.01%
+ Complexity 2975 2972 -3
============================================
Files 340 340
Lines 9837 9828 -9
Branches 1179 1178 -1
============================================
- Hits 8157 8149 -8
- Misses 1163 1164 +1
+ Partials 517 515 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: JermaineHua <crazyhzm@apache.org>
Summary by CodeRabbit
rpc.coredependency to 5.13.2.sofaBootRpcStartListenermethod in theSofaRpcAutoConfigurationclass.lookoutCollectDisableproperty in theSofaBootRpcStartListenerclass, including associated methods.