Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized ark console version registry #17

Merged

Conversation

glmapper
Copy link
Collaborator

No description provided.

卫恒 and others added 6 commits May 21, 2019 21:37
# Conflicts:
#	sofa-dashboard-backend/sofa-dashboard-governance/src/main/java/com/alipay/sofa/dashboard/listener/sofa/SofaRegistryRestClient.java
@glmapper glmapper self-assigned this May 29, 2019
@glmapper glmapper added the enhancement New feature or request label May 29, 2019
@glmapper glmapper requested a review from caojie09 May 29, 2019 07:21
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d0c40e0). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   41.25%           
  Complexity        ?      182           
=========================================
  Files             ?       39           
  Lines             ?     1287           
  Branches          ?      152           
=========================================
  Hits              ?      531           
  Misses            ?      697           
  Partials          ?       59
Impacted Files Coverage Δ Complexity Δ
...ofa/dashboard/cache/SofaRegistryDataCacheImpl.java 85.18% <ø> (ø) 12 <0> (?)
...dashboard/listener/ApplicationStartedListener.java 88.88% <ø> (ø) 4 <0> (?)
...ashboard/cache/ZookeeperRegistryDataCacheImpl.java 30.12% <ø> (ø) 8 <0> (?)
...ashboard/listener/sofa/SofaRegistryRestClient.java 45.94% <ø> (ø) 11 <0> (?)
...shboard/configuration/GovernanceConfiguration.java 100% <ø> (ø) 10 <0> (?)
...alipay/sofa/dashboard/cache/RegistryDataCache.java 0% <ø> (ø) 0 <0> (?)
...ipay/sofa/dashboard/impl/ZkCommandPushManager.java 2.77% <0%> (ø) 2 <0> (?)
...om/alipay/sofa/dashboard/model/ArkPluginModel.java 84.61% <100%> (ø) 11 <2> (?)
...a/com/alipay/sofa/dashboard/model/ArkPluginDO.java 95% <50%> (ø) 10 <1> (?)
.../alipay/sofa/dashboard/impl/ArkMngServiceImpl.java 58.82% <90%> (ø) 9 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c40e0...bdb3b29. Read the comment docs.

@caojie09 caojie09 merged commit f4a0f58 into sofastack:master May 30, 2019
@glmapper
Copy link
Collaborator Author

#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants