Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sb compatible #107

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Feat/sb compatible #107

merged 12 commits into from
Nov 10, 2023

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Nov 3, 2023

Make StringBuilder and StringBuffer compatible under jdk 8 and jdk11+

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (8158da2) 28.47% compared to head (d7b917f) 28.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #107      +/-   ##
==========================================
+ Coverage   28.47%   28.75%   +0.28%     
==========================================
  Files         171      173       +2     
  Lines       11731    11864     +133     
  Branches     2114     2134      +20     
==========================================
+ Hits         3340     3412      +72     
- Misses       8044     8091      +47     
- Partials      347      361      +14     
Files Coverage Δ
...cho/hessian/io/AbstractFieldAdaptorSerializer.java 73.46% <80.00%> (+0.29%) ⬆️
...sian/io/throwable/StackTraceElementSerializer.java 66.10% <70.00%> (-0.57%) ⬇️
.../java/com/caucho/hessian/io/SerializerFactory.java 81.26% <27.27%> (-1.86%) ⬇️
...ho/hessian/io/AbstractStringBuilderSerializer.java 14.63% <14.63%> (ø)
.../hessian/io/AbstractStringBuilderDeserializer.java 18.46% <18.46%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lo1nt Lo1nt closed this Nov 6, 2023
@Lo1nt Lo1nt reopened this Nov 6, 2023
@sofastack-cla sofastack-cla bot added the cla:yes label Nov 6, 2023
@sofastack-cla sofastack-cla bot added the size/XL label Nov 9, 2023
@sofastack-cla sofastack-cla bot added size/XXL and removed size/XL labels Nov 10, 2023
Copy link

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt merged commit f35a6aa into sofastack:3.x Nov 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants