Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature, rpc-grpc-impl 适配新版本的 grpc #837

Closed
CherishCai opened this issue May 28, 2022 · 3 comments
Closed

Feature, rpc-grpc-impl 适配新版本的 grpc #837

CherishCai opened this issue May 28, 2022 · 3 comments

Comments

@CherishCai
Copy link

Your question

sofa-jraft 的rpc-grpc-impl 目前开发依赖 grpc = 1.17.0 ，比较久远了，若使用新版 grpc (>1.30.2) 会出现兼容问题。
image

反射获取 NettyServerStream.class 的 "channel" 属性
image

直至 grpc = 1.30.2 都存在 NettyServerStream.class "channel" 属性
image

更细微版本没关注，而 grpc = 1.32.3 的 NettyServerStream.class 已经没有 "channel" 属性。唯有先让 rpc-grpc-impl 更新版本适配。
image

Your scenes

开一个 1.4.x 分支，适配追近 grpc 到新版本。

Your advice

@fengjiachun 家纯大佬

Environment

  • SOFAJRaft version: 1.3.10-bugfix
  • JVM version (e.g. java -version): 1.8 .0_192
  • OS version (e.g. uname -a): Mac
  • Maven version: 3.6.3
  • IDE version: xx
@CherishCai CherishCai mentioned this issue May 28, 2022
Closed
5 tasks
@CherishCai
Copy link
Author

relate #734

This was referenced Jun 9, 2022
Closed
Closed
@seeflood
Copy link
Member

seeflood commented Jun 30, 2022 •
edited
Loading

相关进展见 #841 (comment)

@KomachiSion KomachiSion mentioned this issue Oct 10, 2022
Open
@CherishCai
Copy link
Author

Close by #904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CherishCai @seeflood