Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade grpc to 1.50.2 #904

Merged
merged 1 commit into from
Nov 22, 2022
Merged

upgrade grpc to 1.50.2 #904

merged 1 commit into from
Nov 22, 2022

Conversation

KomachiSion
Copy link
Contributor

@KomachiSion KomachiSion commented Nov 17, 2022 •
edited
Loading

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #734 and #841 .

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot
Copy link

sofastack-bot bot commented Nov 17, 2022

Hi @KomachiSion, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@KomachiSion KomachiSion reopened this Nov 17, 2022
@sofastack-bot
Copy link

sofastack-bot bot commented Nov 17, 2022

Hi @KomachiSion, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@KomachiSion KomachiSion reopened this Nov 18, 2022
@sofastack-bot
Copy link

sofastack-bot bot commented Nov 18, 2022

Hi @KomachiSion, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@fengjiachun
Copy link
Contributor

check_format 失败，可以本地先执行一下 mvn compile（会自动 format） 再提交代码

@fengjiachun
Copy link
Contributor

也需要签一下 CLA， 感谢

@sofastack-bot sofastack-bot bot added the size/S label Nov 21, 2022
@KomachiSion
Copy link
Contributor Author

image
reformat code finished, CLA signed but check can't pass.

@KomachiSion KomachiSion reopened this Nov 21, 2022
@KomachiSion KomachiSion mentioned this pull request Nov 22, 2022
Closed
fengjiachun
fengjiachun approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit fadca3e into sofastack:master Nov 22, 2022
@fengjiachun
Copy link
Contributor

@KomachiSion tks

@killme2008
Copy link
Contributor

Good job:+1

@CherishCai CherishCai mentioned this pull request Nov 22, 2022
Closed
@KomachiSion KomachiSion deleted the master-issue#734 branch November 22, 2022 10:01
@KomachiSion
Copy link
Contributor Author

@fengjiachun Is there plan to release recently?

@fengjiachun
Copy link
Contributor

@fengjiachun Is there plan to release recently?

ASAP

@fengjiachun fengjiachun mentioned this pull request Dec 13, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
cla:no cla:yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sofa-jraft依赖的grpc1.17.0版本老旧而且缺陷多，建议升级依赖版本
3 participants
@KomachiSion @fengjiachun @killme2008