结合 NWR 实现 Flexible raft #1005
Closed
结合 NWR 实现 Flexible raft #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
辛苦啦，rfc可以单独提交pr |
killme2008
reviewed
Jul 2, 2023
rfcs/0002-Flexible-Raft-with-NWR.md
Outdated
| ``` | ||
| private boolean checkAndResetFactor(Double writeFactor, Double readFactor){ | ||
| if (Objects.nonNull(readFactor) && Objects.nonNull(writeFactor)) { | ||
| if (readFactor + writeFactor != 1) { |
There was a problem hiding this comment.
We can't compare integer type(1) with float type(readFactor + writeFactor) precisely. I think we can change the readFactor and writeFactor to be int types, and ensure that their sum is 10. Their range both are (0,10).
There was a problem hiding this comment.
Does this mean that if the user sets readFactor to 4 and writeFactor to 6. If in a cluster with 5 nodes, writeQuorum as 5 * 0.6=3 and readQuorum as n-w+1=5-3+1=3
There was a problem hiding this comment.
Yes， that's my point @1294566108
# Conflicts: # jraft-core/src/main/java/com/alipay/sofa/jraft/Quorum.java # jraft-core/src/main/java/com/alipay/sofa/jraft/core/BallotBox.java # jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java # jraft-core/src/main/java/com/alipay/sofa/jraft/entity/MajorityQuorum.java # jraft-core/src/main/java/com/alipay/sofa/jraft/entity/NWRQuorum.java # jraft-core/src/main/java/com/alipay/sofa/jraft/entity/QuorumConfiguration.java # jraft-core/src/main/java/com/alipay/sofa/jraft/entity/QuorumFactory.java # jraft-core/src/main/java/com/alipay/sofa/jraft/option/NodeOptions.java # jraft-core/src/test/java/com/alipay/sofa/jraft/entity/NWRQuorumTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ospp开源之夏-2023-结合 NWR 实现 Flexible raft，用于自定义 Quorum 的大小
Modification:
新增QuorumNWQ设计文档至rfcs
Result:
Fixes #<1003>.