(fix) Impl moving file atomically on windows, #54 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
Apr 16, 2019
| Files.deleteIfExists(tmpPath); | ||
| } catch (IOException e2) { | ||
| e2.addSuppressed(e1); | ||
| LOG.warn("Unable to delete {}, good bye then!", tmpPath); |
There was a problem hiding this comment.
这行日志不错： good bye then!
There was a problem hiding this comment.
已经到 good bye 地步了的话，日志 level 是不是应该为 error？
There was a problem hiding this comment.
没有必要，上层会 catch 打印
| } | ||
|
|
||
| if (destFile.exists()) { | ||
| LOG.info("The target file { } was already existing", destPath); |
There was a problem hiding this comment.
大括号多了一个空格，另外日志是一句话，应该有一个句号
| Path destPath = destFile.toPath(); | ||
| try { | ||
| return Files.move(tmpPath, destPath, StandardCopyOption.ATOMIC_MOVE) == destPath; | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
final IOException e
按照 jraft 的统一代码风格，应该有个 final 修饰
fengjiachun
reviewed
Apr 16, 2019
| @@ -96,6 +105,7 @@ private void readBytes(byte[] bs, InputStream input) throws IOException { | |||
| * @return true if save success | |||
There was a problem hiding this comment.
这些东西应该工具来保证，如果工具无法做到，我觉的这个规范可以不要了。 javadoc 会处理。
There was a problem hiding this comment.
恩，那这个规范就不要了，没有必要去手工调整。参数合理说明即可。生成的 javadoc 会格式化的。
fengjiachun
reviewed
Apr 16, 2019
| File destFile = new File(this.path); | ||
| Path destPath = destFile.toPath(); | ||
| try { | ||
| return Files.move(tmpPath, destPath, StandardCopyOption.ATOMIC_MOVE) == destPath; |
There was a problem hiding this comment.
Files.move() == destPath 是个恒等式，还不如新起一行 return true 清晰
fengjiachun
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Use
Files.move(source,path,opts)to replaceFile#renameTo(file)for moving files atomically.The code is from
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/AtomicFileWriter.java#L187
Modification:
Modify the
ProtoBufFile#save()implementation.Result:
Fixes #54