chore: remove deprecated method to adapt higher rocksdb version #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after test case succeeded, I will restore the default rocksdb config |
|
Looking forward to merging soon, RocketMQ is introducing jraft, but jraft has employed deprecated methods from an older version of rocksdb, resulting in unexpected startup failures. |
|
cc @fengjiachun |
|
Hi @fengjiachun , I'm curious to know whether there's an upcoming release planned in the near future. We are looking forward that JRaft can be applied to RocketMQ ASAP :-) apache/rocketmq#7301 |
|
I plan to release this month(maybe as soon as next week). I will first do a Jepsen validation, and once it has been verified, I will proceed to the release. The detailed process will be continuously updated in this issue. |
|
thanks，we will test soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
after upgrade the new version， I removed all deprecated method
Result:
Fixes #1057
If there is no issue then describe the changes introduced by this PR.