fix: refresh leader on disconnect #1140
Conversation
WalkthroughRecent changes enhance the error handling mechanisms in the jraft framework by introducing a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant BoltRpcClient
participant ConnectionFailureException
participant RheaKVRpcService
Client->>BoltRpcClient: invokeSync(request)
BoltRpcClient-->>ConnectionFailureException: Check for ConnectException
ConnectionFailureException-->>BoltRpcClient: Throw ConnectionFailureException
BoltRpcClient->>RheaKVRpcService: Handle connection error
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- jraft-core/src/main/java/com/alipay/sofa/jraft/error/ConnectionFailureException.java (1 hunks)
- jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java (4 hunks)
- jraft-core/src/main/java/com/alipay/sofa/jraft/util/internal/ThrowUtil.java (1 hunks)
- jraft-rheakv/rheakv-core/src/main/java/com/alipay/sofa/jraft/rhea/client/DefaultRheaKVRpcService.java (3 hunks)
- jraft-rheakv/rheakv-core/src/main/java/com/alipay/sofa/jraft/rhea/client/pd/DefaultPlacementDriverRpcService.java (3 hunks)
Additional comments not posted (9)
jraft-core/src/main/java/com/alipay/sofa/jraft/error/ConnectionFailureException.java (1)
1-45: New Exception Class Added:ConnectionFailureException.The new class
ConnectionFailureExceptionis well-structured, providing multiple constructors for flexibility in handling RPC connection failures. This addition enhances error handling granularity.jraft-core/src/main/java/com/alipay/sofa/jraft/util/internal/ThrowUtil.java (2)
69-75: New Method Added:getRootCause.The
getRootCausemethod effectively traverses the cause chain to find the root cause of aThrowable. This utility enhances error diagnostics.
64-64: Improvement incutCauseMethod.The
cutCausemethod now sets the stack trace to that of the root cause, enhancing the accuracy of error reporting.jraft-rheakv/rheakv-core/src/main/java/com/alipay/sofa/jraft/rhea/client/pd/DefaultPlacementDriverRpcService.java (3)
28-28: Improved Error Handling:ConnectionFailureExceptionImport.The import of
ConnectionFailureExceptionaligns with the enhanced error handling strategy focused on connection failures.
114-114: Simplified Error Handling incompleteMethod.The removal of specific handling for
RemotingExceptionin favor of a generalized approach simplifies the error handling logic.
126-132: Refined Error Handling inexecutorMethod.The catch block now explicitly handles
ConnectionFailureException, improving specificity and robustness in error management.jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/BoltRpcClient.java (2)
124-126: Consistent error handling is approved.The handling of
ConnectExceptionininvokeAsyncaligns withinvokeSync, ensuring consistency.Verify that
ConnectionFailureExceptionis consistently handled throughout the codebase.
106-108: Enhanced error handling is approved.The addition of
ConnectionFailureExceptionforConnectExceptionimproves error granularity and diagnostics.Ensure that
ConnectionFailureExceptionis properly handled in other parts of the codebase to maintain robustness.Verification successful
ConnectionFailureExceptionis properly handled in the codebase.The exception is checked in key classes such as
DefaultRheaKVRpcServiceandDefaultPlacementDriverRpcService, indicating that the error handling is robust and consistent across the codebase.
DefaultRheaKVRpcService: Checks forConnectionFailureException.DefaultPlacementDriverRpcService: Checks forConnectionFailureException.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify handling of `ConnectionFailureException` throughout the codebase. # Test: Search for the usage of `ConnectionFailureException`. Expect: Proper handling in all relevant locations. rg --type java 'ConnectionFailureException'Length of output: 2976
jraft-rheakv/rheakv-core/src/main/java/com/alipay/sofa/jraft/rhea/client/DefaultRheaKVRpcService.java (1)
156-161: Streamlined error handling is approved.The specific handling of
ConnectionFailureExceptionimproves clarity and reduces redundancy.Ensure that
ConnectionFailureExceptionhandling is consistent across the codebase.
|
This change won't affect the Jepsen test results. I think we can release |
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit
New Features
ConnectionFailureExceptionfor improved error handling related to RPC connection failures.getRootCauseto enhance exception diagnostics.Bug Fixes
BoltRpcClientto differentiate connection failures from other remoting exceptions.DefaultRheaKVRpcServiceandDefaultPlacementDriverRpcServicefor consistency in handling connection errors.Documentation