fix/log storage minor fix #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个单测问题我跟下，感觉还是有隐藏的问题。 |
Log 的 disruptorBufferSize 太小了（1024）？或者 tryOfferEvent 失败重试是不是应该指数避让而非 spin 后直接重试？ 看起来 spin 一般还是失败 |
|
@fengjiachun 不是这个问题，这个错误是单元测试里故意设计的一个场景。目前看应该是 snapshot 安装失败引起的，另一个测试用例。 |
killme2008
approved these changes
Jun 27, 2019
fengjiachun
pushed a commit
that referenced
this pull request
Sep 12, 2019
* (feat) Impl a segment log storage, #39 * (feat) revert test log level * (feat) adds more log * (feat) Use partitioned index filters for rocksdb block based table config, bump rocksdb to 5.18.3 * (fix) comments * (feat) format segment file name * (feat) reserve 2 bytes for location metadata * (fix) hang on shutdown * (feat) refactor and add unit test for segment storage * (fix) race condition in doCheckpoint * (feat) touch abort file * (feat) refactor * (feat) minor changes in RocksDBSegmentLogStorage#onShutdown * fix/log storage minor fix (#191) * (fix) minor fix * (fix) minor fix * (fix) minor fix * (feat) minor changes in RocksDBSegmentLogStorage#onShutdown * (fix) remove special characters * (fix) forgot to reset buffer position when truncating segment file * (feat) minor changes * (feat) remove writeLock in checkpoint thread * (feat) Compare reference instead of array's length * feat/follow by storagev2 (#196) * (feat) follow logStorage's tableConfig * (fix) fix javadoc * (fix) format * (fix) log storage text path * (fix) compare ref is better * (fix) format * (fix) ut fix * (fix) lambda * fix/read after shutdown (#215) * (fix) read after db shutdown * (fix) check state before access db * (fix) by review comments * (fix) RocksDBSegmentLogStorage#onTruncateSuffix when last log not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
minor fix
Modification:
Result: