-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/raft stat describer #208
Conversation
file: node_metrics.log.USR2.2019-07-13_15-28-15
|
file: rheakv_metrics.log.USR2.2019-07-13_15-28-15
|
jraft-core/src/main/java/com/alipay/sofa/jraft/NodeDescribeSignalHandler.java
Show resolved
Hide resolved
final NodeMetrics nodeMetrics = node.getNodeMetrics(); | ||
final MetricRegistry registry = nodeMetrics.getMetricRegistry(); | ||
if (registry == null) { | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议加个 warn log,当没启用统计的时候
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
} | ||
} | ||
} catch (final Throwable t) { | ||
LOG.warn("Fail to add signal.", t); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error,不应该是 warn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
package com.alipay.sofa.jraft.util; | ||
|
||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加个类说明
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
public void handle(final sun.misc.Signal signal) { | ||
try { | ||
if (!this.target.equals(signal)) { | ||
LOG.info("Unexpected signal: {}.", signal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行日志似乎不需要,还容易带来误解
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done,是应该去掉,会带来误解
Motivation:
Add sig_usr2 handler, do not support windows
Show all raft nodes state info, node metric and rheakv metric
TODO:
Modification:
Add
JRaftSignalHandler
based of SPI-
NodeMetricsSignalHandler
for node metrics-
NodeDescribeSignalHandler
for node describe-
RheaKVMetricsSignalHandler
for rheakv metricAdd
Describer
to describe raft stateAdd
MetricReporter
to print metricResult:
~ kill -s SIGUSR2 pid
example:
Fixes #103