Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Iterator#setErrorAndRollback may break ReadIndex promise, #317 #361

Merged
merged 6 commits into from
Nov 30, 2019
Merged

(fix) Iterator#setErrorAndRollback may break ReadIndex promise, #317 #361

merged 6 commits into from
Nov 30, 2019

Conversation

killme2008
Copy link
Contributor

Motivation:

Try to fix #317

Modification:

  • A test case to reproduce this issue.
  • Notify with lastIndex instead of commitIndex in FSMCaller#doCommit
  • Reset pending read index statuses with error if it presents.

Result:

Fixes #317

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/L labels Nov 29, 2019
@killme2008 killme2008 mentioned this pull request Nov 29, 2019
Closed
11 tasks
@killme2008
Copy link
Contributor Author

@fengjiachun 是 FSMCallerTest#testOnCommittedError 引起的，我修复了

@fengjiachun fengjiachun merged commit f8d84b6 into master Nov 30, 2019
@fengjiachun fengjiachun deleted the feature/fix-317 branch November 30, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke Iterator#setErrorAndRollback when applying logs to state machine may break ReadIndex promise
2 participants
@killme2008 @fengjiachun