(feat) Set segment file to be read-only after write and sync #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
Mar 30, 2020
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/log/RocksDBSegmentLogStorage.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/log/RocksDBSegmentLogStorage.java
Show resolved
Hide resolved
fengjiachun
approved these changes
Mar 30, 2020
SteNicholas
approved these changes
Mar 30, 2020
zongtanghu
pushed a commit
that referenced
this pull request
Apr 28, 2020
* (feat) Set segment file to be read-only after write and sync * (feat) use CopyOnWriteArrayList for hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Segment file may be swapped out(unmap) when writing, then the JVM may crash.The segment file is swapped out only when it's readonly. So we must make sure the segment file to be set readonly after all writing/fsync requests are finished.
So this PR adds finish hooks to
WriteContext, all these hooks will be invoked after writing and fsync. It movecurrLastFile.setReadOnly(true)from write-executor to a finish hook, so we make sure that the segment file is set readonly only after all writing/fsync requests are finished.