-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/grpc impl #433
Merged
Merged
feat/grpc impl #433
+7,063
−1,786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
force-pushed
the
feat/grpc_impl
branch
2 times, most recently
from
April 29, 2020 07:24
0f1e1b7
to
ff495b9
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
3 times, most recently
from
May 1, 2020 07:20
5dffaa7
to
e8be90b
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 2, 2020 16:09
e8be90b
to
12e420d
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 2, 2020 16:49
6cc8768
to
94392af
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 2, 2020 18:17
94392af
to
e9b9aa4
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 6, 2020 13:14
ec8fe5b
to
2496d64
Compare
SteNicholas
approved these changes
May 6, 2020
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 7, 2020 03:21
2496d64
to
eaabdec
Compare
SteNicholas
approved these changes
May 7, 2020
我今天看下 |
killme2008
reviewed
May 7, 2020
killme2008
reviewed
May 7, 2020
killme2008
reviewed
May 7, 2020
jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/cli/AddLearnersRequestProcessor.java
Outdated
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/cli/AddPeerRequestProcessor.java
Outdated
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/cli/GetLeaderRequestProcessor.java
Outdated
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
jraft-core/src/main/java/com/alipay/sofa/jraft/rpc/impl/cli/RemoveLearnersRequestProcessor.java
Outdated
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
@@ -27,6 +27,7 @@ message InstallSnapshotRequest { | |||
message InstallSnapshotResponse { | |||
required int64 term = 1; | |||
required bool success = 2; | |||
optional ErrorResponse errorResponse = 99; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protobuf 支持定义常量吗? 这样重复写 99 不大好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
查了下应该是不支持
killme2008
reviewed
May 7, 2020
...xtension/rpc-grpc-impl/src/main/java/com/alipay/sofa/jraft/rpc/impl/GrpcResponseFactory.java
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
jraft-extension/rpc-grpc-impl/src/main/java/com/alipay/sofa/jraft/rpc/impl/GrpcServer.java
Outdated
Show resolved
Hide resolved
killme2008
reviewed
May 7, 2020
jraft-extension/rpc-grpc-impl/src/test/java/com/alipay/sofa/jraft/test/MockAsyncContext.java
Show resolved
Hide resolved
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 7, 2020 12:33
92b73b1
to
fb2ec7f
Compare
fengjiachun
force-pushed
the
feat/grpc_impl
branch
2 times, most recently
from
May 9, 2020 11:08
ad223d4
to
7a8514c
Compare
* grpc server interceptor
fengjiachun
force-pushed
the
feat/grpc_impl
branch
from
May 9, 2020 11:23
7a8514c
to
7927813
Compare
zongtanghu
pushed a commit
that referenced
this pull request
May 26, 2020
* jraft grpc rpc implement (#427) Co-authored-by: SteNicholas <programgeek@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.