Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/grpc impl #433

Merged
merged 12 commits into from
May 12, 2020
Merged

feat/grpc impl #433

merged 12 commits into from
May 12, 2020

Conversation

fengjiachun
Copy link
Contributor

No description provided.

@fengjiachun fengjiachun force-pushed the feat/grpc_impl branch 3 times, most recently from 5dffaa7 to e8be90b Compare May 1, 2020 07:20
@fengjiachun fengjiachun changed the title [WIP]feat/grpc impl feat/grpc impl May 2, 2020
@killme2008
Copy link
Contributor

我今天看下

jraft-core/pom.xml Outdated Show resolved Hide resolved
@@ -27,6 +27,7 @@ message InstallSnapshotRequest {
message InstallSnapshotResponse {
required int64 term = 1;
required bool success = 2;
optional ErrorResponse errorResponse = 99;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf 支持定义常量吗? 这样重复写 99 不大好

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

查了下应该是不支持

@fengjiachun fengjiachun force-pushed the feat/grpc_impl branch 2 times, most recently from ad223d4 to 7a8514c Compare May 9, 2020 11:08
* grpc server interceptor
@fengjiachun fengjiachun merged commit 59853a7 into master May 12, 2020
@fengjiachun fengjiachun deleted the feat/grpc_impl branch May 12, 2020 07:26
zongtanghu pushed a commit that referenced this pull request May 26, 2020
* jraft grpc rpc implement (#427)
Co-authored-by: SteNicholas <programgeek@163.com>
@fengjiachun fengjiachun mentioned this pull request Jun 19, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants