fail-fast on connection fail #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
reviewed
May 12, 2021
| executor.execute(() -> { | ||
| if (done != null) { | ||
| try { | ||
| done.run(new Status(RaftError.EINTERNAL, "Check connection[%s] fail and try to create new one", endpoint)); |
There was a problem hiding this comment.
in line_159 and line_165, the message format way can be unify.
one use string format, another one use string splicing.
killme2008
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
check the connection first and fail-fast (asynchronously to create the connection) on pre-vote and vote
Modification:
Result:
Fixes #583 .
If there is no issue then describe the changes introduced by this PR.