Not interrupt thread when cancel #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofastack-bot
bot
added
cla:yes
question
fengjiachun
reviewed
Aug 25, 2021
jraft-core/src/main/java/com/alipay/sofa/jraft/util/timer/DefaultTimer.java
Show resolved
Hide resolved
fengjiachun
reviewed
Aug 26, 2021
| @@ -113,6 +115,9 @@ public void setFuture(ScheduledFuture<?> future) { | |||
|
|
|||
| @Override | |||
| public void run() { | |||
| if (cancel) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
增加这个状态字段我个人觉得其实没有必要，本身 ScheduledFuture 就会对我们的 task 再包装一层，其中有 state 字段并包含 CANCELLED 状态，说白了，处理机制就和你现在增加的逻辑类似，所以这里可以理解为重复操作
|
好像是的。。。在timer的场景来说，只有可以让当前已经在run的task跑完。避免下次跑就ok
发自我的iPhone
…------------------ Original ------------------
From: block ***@***.***>
Date: Thu,Aug 26,2021 9:39 AM
To: sofastack/sofa-jraft ***@***.***>
Cc: 赵延 ***@***.***>, Author ***@***.***>
Subject: Re: [sofastack/sofa-jraft] Not interrupt thread when cancel (#671)
@fengjiachun commented on this pull request.
In jraft-core/src/main/java/com/alipay/sofa/jraft/util/timer/DefaultTimer.java:
> final ScheduledFuture<?> f = future; - return f != null && f.cancel(true); + return f != null && f.cancel(false);
中断是用于处理在执行中的任务，你加那个标注为是无效的
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #669