-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom thread pool #855
custom thread pool #855
Conversation
this is the implementation of issue #853 |
Main changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution, but i found some problems. Feel free to discuss with us.
And i hope you can rebase the commit history, we hope the commit log clean and meanful.
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/closure/ClosureQueueImpl.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/BootstrapOptions.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/NodeOptions.java
Outdated
Show resolved
Hide resolved
94e35ef
to
5a50413
Compare
jraft-core/src/main/java/com/alipay/sofa/jraft/closure/ClosureQueueImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/FSMCallerImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/FSMCallerImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/impl/RocksDBLogStorage.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/snapshot/local/LocalSnapshotCopier.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great and amost done, but i have some comments above, please checking them and discuss with me if you have problems. Thank you for your great work. @farawayliu
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/NodeOptions.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
custom thread pool, todo: DefaultFixedThreadsExecutorGroupFactory.toString
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.