-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadOnlyOption 支持请求级别 #867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fengjiachun
reviewed
Jul 26, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/ReadOnlyServiceImpl.java
Outdated
Show resolved
Hide resolved
fengjiachun
reviewed
Jul 28, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/ReadOnlyServiceImpl.java
Outdated
Show resolved
Hide resolved
fengjiachun
reviewed
Jul 28, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/ReadOnlyServiceImpl.java
Show resolved
Hide resolved
fengjiachun
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qiujiayu
pushed a commit
to qiujiayu/sofa-jraft
that referenced
this pull request
Aug 6, 2022
* Readonlyoption supports request levels * Readonlyoption supports request levels * global read only option * fix test * rpc msg use enum for readonlyoption * refactor method: executeReadIndexEvents * refactor method: executeReadIndexEvents Co-authored-by: tynan.liu <tynan.liu@xinjifamily.com>
qiujiayu
pushed a commit
to qiujiayu/sofa-jraft
that referenced
this pull request
Aug 6, 2022
* Readonlyoption supports request levels * Readonlyoption supports request levels * global read only option * fix test * rpc msg use enum for readonlyoption * refactor method: executeReadIndexEvents * refactor method: executeReadIndexEvents Co-authored-by: tynan.liu <tynan.liu@xinjifamily.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.