Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: add exec-maven-plugin version #878

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

xtr1993
Copy link
Contributor

@xtr1993 xtr1993 commented Sep 10, 2022

Describe the bug
When I compile the project, I find exec-maven-plugin unkown,Because this plugin does not specify a version number

Expected behavior
Compilation failed

Actual behavior
Compilation failed

Steps to reproduce
mvn clean install

Minimal yet complete reproducer code (or GitHub URL to code)
Environment
SOFABolt version:
JVM version (e.g. java -version):
OS version (e.g. uname -a):
Maven version:
IDE version:

@sofastack-bot
Copy link

sofastack-bot bot commented Sep 10, 2022

Hi @xtr1993, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@xtr1993
Copy link
Contributor Author

xtr1993 commented Sep 11, 2022

@killme2008 help me review , thank u

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtr1993
Copy link
Contributor Author

xtr1993 commented Sep 13, 2022

LGTM

Hi, this CI running to long time in test_jraft_core,test modules have some exceptions

@killme2008 killme2008 merged commit 41421c1 into sofastack:master Sep 17, 2022
@fengjiachun fengjiachun mentioned this pull request Dec 13, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants