Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rocksdb version to 7.7.3 #896

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

qiujiayu
Copy link
Contributor

@qiujiayu qiujiayu commented Nov 5, 2022

Motivation:

RocksDB 7 终于解决了 Compaction 时性能下降问题

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@fengjiachun
Copy link
Contributor

好像 jraft-core 单侧无法通过?

@qiujiayu
Copy link
Contributor Author

qiujiayu commented Nov 8, 2022

好像 jraft-core 单侧无法通过?

嗯,我看看是怎么回事。

@qiujiayu
Copy link
Contributor Author

qiujiayu commented Nov 8, 2022

好像 jraft-core 单侧无法通过?

Master的 NodeTest 也是有问题的,应该不是这次变更造成的。

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@fengjiachun Take a look

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit c185f58 into sofastack:master Nov 16, 2022
@fengjiachun
Copy link
Contributor

@qiujiayu tks

@fengjiachun fengjiachun mentioned this pull request Dec 13, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants