-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iterator):Auto commit mode for applying log iterator #962
Conversation
jraft-core/src/main/java/com/alipay/sofa/jraft/core/IteratorImpl.java
Outdated
Show resolved
Hide resolved
@1294566108 I think we should call while(it.hasNext()) {
byte [] data = it.getData();
it.commit();
it.next();
} It looks like we don't need the variable |
@1294566108 Please sign the CLA and format the code by |
Okay, I have recompiled and submitted it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few suggestions. Please sign the CLA http://cla.sofastack.tech/
jraft-core/src/main/java/com/alipay/sofa/jraft/core/IteratorWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@1294566108 You have to sign the CLA http://cla.sofastack.tech/ If not, we can't merge this PR. thank you. |
|
@seeflood Hi, the new contributor's CLA state can't be updated again, please help to check it. |
Motivation:
Auto commit mode for applying log iterator
Modification:
issue link is here.
Result: