Registry polaris #1147

ZLBer · 2021-12-16T11:27:31Z

Motivation:

add a new registry component polaris , the project website : https://github.com/polarismesh/polaris , https://polarismesh.cn/#/
related issue: polarismesh/polaris#163

Modification:

add a new registry component polaris, the code logic is similar to consul registry.

Result:

Fixes #1141 .

sofastack-bot · 2021-12-16T11:27:35Z

Hi @ZLBer, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

seeflood · 2021-12-16T11:49:20Z

ZLB niu b!

OrezzerO · 2021-12-16T13:44:40Z

ZLB niu b!

ujjboy

感谢 PR，我看目前是有一个示例，这个能否补充一个单测呢？

example/src/test/java/com/alipay/sofa/rpc/polaris/PolarisBoltClientMain.java

example/src/test/java/com/alipay/sofa/rpc/polaris/PolarisBoltServerMain.java

ZLBer · 2021-12-17T13:23:25Z

感谢 PR，我看目前是有一个示例，这个能否补充一个单测呢？

单测在 registry/registry-polaris/src/test/java/com/alipay/sofa/rpc/registry/polaris/PolarisRegistryTest.java

EvenLjj · 2021-12-20T07:49:18Z

@ZLBer Welcome, build fail in PMD check. The detail info [INFO] PMD Failure: com.alipay.sofa.rpc.registry.polaris.PolarisRegistry:204 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'response'... Please remove the unusedLocalVariable and run again.

ZLBer · 2021-12-20T14:54:18Z

@EvenLjj done~

EvenLjj · 2021-12-21T09:01:52Z

@ZLBer Please run mvn clean compile -DskipTests in local before git commit. It will format the code.

ZLBer · 2021-12-21T14:40:52Z

@EvenLjj sorry，formatted it

codecov · 2021-12-21T15:56:43Z

Codecov Report

Merging #1147 (a4bbd7d) into master (0c84e0a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1147      +/-   ##
============================================
+ Coverage     71.08%   71.12%   +0.03%     
- Complexity      825      826       +1     
============================================
  Files           407      407              
  Lines         17199    17199              
  Branches       2681     2681              
============================================
+ Hits          12226    12232       +6     
+ Misses         3597     3589       -8     
- Partials       1376     1378       +2

Impacted Files	Coverage Δ
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java	`81.48% <0.00%> (-0.93%)`	⬇️
...java/com/alipay/sofa/rpc/module/LookoutModule.java	`85.71% <0.00%> (+33.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c84e0a...a4bbd7d. Read the comment docs.

chuntaojun · 2022-01-14T03:41:26Z

hello。这里sofa-rpc社区的同学能辛苦在帮忙review看看吗

EvenLjj · 2022-01-20T03:02:45Z

@ZLBer @chuntaojun Sorry for the delay, we will review as soon as possible. If there is no problem with the review, this will release in a rpc feature release version.

...try/registry-polaris/src/main/java/com/alipay/sofa/rpc/registry/polaris/PolarisRegistry.java

registry/registry-polaris/pom.xml

...try/registry-polaris/src/main/java/com/alipay/sofa/rpc/registry/polaris/PolarisRegistry.java

registry/registry-polaris/pom.xml

EvenLjj

LGTM

chuntaojun · 2022-02-21T03:19:06Z

希望可以快点合并到sofa-rpc仓库主分支中去～

# Conflicts: # example/pom.xml

…polaris

ujjboy · 2022-03-07T08:20:10Z

代码没啥问题啦，合并后请在这边补充一下文档。

https://github.com/sofastack/sofastack.tech/tree/master/content/zh/projects/sofa-rpc

OrezzerO

Some bug need to be fixed.

OrezzerO · 2022-03-07T11:58:03Z

...stry/registry-polaris/src/main/java/com/alipay/sofa/rpc/registry/polaris/PolarisWatcher.java

+        getAllInstancesRequest.setNamespace(nameSpace);
+        getAllInstancesRequest.setService(serviceName);
+        this.currentData = consumerAPI.getAllInstance(getAllInstancesRequest);
+        this.watchExecutor = Executors.newSingleThreadScheduledExecutor();


It's too expensive that each consumer holds a thread.

@OrezzerO so, should exceute them in one threadPool ?

...try/registry-polaris/src/main/java/com/alipay/sofa/rpc/registry/polaris/PolarisRegistry.java

ZLBer added 6 commits December 10, 2021 20:26

support polaris registry

0d3352e

support polaris registry

f4f55b7

support polaris registry

fc102ba

add ut

41216de

support polaris registry

259c24b

Merge branch 'master' into registry-polaris

034cef2

sofastack-bot bot added cla:no Need sign CLA First-time contributor First-time contributor size/XXL labels Dec 16, 2021

sofastack-bot bot added cla:yes CLA is ok and removed cla:no Need sign CLA labels Dec 16, 2021

ujjboy requested changes Dec 17, 2021

View reviewed changes

example/src/test/java/com/alipay/sofa/rpc/polaris/PolarisBoltClientMain.java Outdated Show resolved Hide resolved

example/src/test/java/com/alipay/sofa/rpc/polaris/PolarisBoltServerMain.java Outdated Show resolved Hide resolved

chuntaojun mentioned this pull request Dec 17, 2021

🔥 Extend Polaris Ecosystem polarismesh/polaris#163

Open

53 tasks

fix author

fa8c9d2

remove unused var

03c1877

format code

f65a27f

nobodyiam requested review from OrezzerO and EvenLjj January 18, 2022 13:29

EvenLjj reviewed Jan 25, 2022

View reviewed changes

ZLBer and others added 3 commits January 26, 2022 23:41

code fix

44f7c8b

ut fix

c9721e9

format code

93456ac

EvenLjj approved these changes Feb 21, 2022

View reviewed changes

ZLBer added 2 commits February 25, 2022 15:06

Merge branch 'master' into registry-polaris

c4096ba

# Conflicts: # example/pom.xml

Merge remote-tracking branch 'origin/registry-polaris' into registry-…

a4bbd7d

…polaris

EvenLjj added this to the 5.8.4 milestone Mar 2, 2022

nobodyiam requested a review from ujjboy March 7, 2022 01:38

ujjboy approved these changes Mar 7, 2022

View reviewed changes

EvenLjj merged commit 76d26c5 into sofastack:master Mar 7, 2022

OrezzerO reviewed Mar 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Registry polaris #1147

Registry polaris #1147

ZLBer commented Dec 16, 2021 •

edited

Loading

sofastack-bot bot commented Dec 16, 2021

seeflood commented Dec 16, 2021

OrezzerO commented Dec 16, 2021

ujjboy left a comment

ZLBer commented Dec 17, 2021

EvenLjj commented Dec 20, 2021 •

edited

Loading

ZLBer commented Dec 20, 2021

EvenLjj commented Dec 21, 2021 •

edited

Loading

ZLBer commented Dec 21, 2021

codecov bot commented Dec 21, 2021 •

edited

Loading

chuntaojun commented Jan 14, 2022

EvenLjj commented Jan 20, 2022 •

edited

Loading

EvenLjj left a comment

chuntaojun commented Feb 21, 2022

ujjboy commented Mar 7, 2022

OrezzerO left a comment

OrezzerO Mar 7, 2022

ZLBer Mar 7, 2022

Registry polaris #1147

Registry polaris #1147

Conversation

ZLBer commented Dec 16, 2021 • edited Loading

Motivation:

Modification:

Result:

sofastack-bot bot commented Dec 16, 2021

seeflood commented Dec 16, 2021

OrezzerO commented Dec 16, 2021

ujjboy left a comment

Choose a reason for hiding this comment

ZLBer commented Dec 17, 2021

EvenLjj commented Dec 20, 2021 • edited Loading

ZLBer commented Dec 20, 2021

EvenLjj commented Dec 21, 2021 • edited Loading

ZLBer commented Dec 21, 2021

codecov bot commented Dec 21, 2021 • edited Loading

Codecov Report

chuntaojun commented Jan 14, 2022

EvenLjj commented Jan 20, 2022 • edited Loading

EvenLjj left a comment

Choose a reason for hiding this comment

chuntaojun commented Feb 21, 2022

ujjboy commented Mar 7, 2022

OrezzerO left a comment

Choose a reason for hiding this comment

OrezzerO Mar 7, 2022

Choose a reason for hiding this comment

ZLBer Mar 7, 2022

Choose a reason for hiding this comment

ZLBer commented Dec 16, 2021 •

edited

Loading

EvenLjj commented Dec 20, 2021 •

edited

Loading

EvenLjj commented Dec 21, 2021 •

edited

Loading

codecov bot commented Dec 21, 2021 •

edited

Loading

EvenLjj commented Jan 20, 2022 •

edited

Loading