Support ruby 3 and kwargs (latest) #1
+170
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokus80
reviewed
Dec 11, 2023
mokus80
reviewed
Dec 11, 2023
mokus80
reviewed
Dec 15, 2023
korny
reviewed
Jan 2, 2024
korny
reviewed
Jan 2, 2024
NourEldinShobier
changed the title
…uby3-and-kwargs-support
We need to deserialize jobs that were created before kwargs was available, so when they are not present, they should be inferred using the final hash argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we move the changes proposed in the main repo PR collectiveidea#1158 for handling Ruby3 and kwargs