Alloy metric recording fixes and additions #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether or not to record metrics must be set at Alloy compile-time. That is, we must decide whether or not to record stats when we compile Alloy itself, not when we compile our Alloy program. This is due to static linkage fun when crates are lazily compiled across codegen units.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Oops, I only ran the tests with the stats feature. Pushed a conditional compilation fix (c0b158f) |
|
Please squash. |
jacob-hughes
force-pushed
the
fix_metrics
branch
from
c0b158f to
0275994
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.