Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gc<T> implement NoFinalize #55

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

jacob-hughes
Copy link
Collaborator

The liveness of each Gc value is calculated independently by the
collector, so it's never necessary to call the drop method of a Gc from
another Gc's finalizer.

The liveness of each Gc value is calculated independently by the
collector, so it's never necessary to call the drop method of a Gc from
another Gc's finalizer.
@ltratt
Copy link
Member

ltratt commented Apr 27, 2022

bors r+

@jacob-hughes
Copy link
Collaborator Author

Not quite sure what's going on here. Looks like bors is down?

@ltratt
Copy link
Member

ltratt commented Apr 27, 2022

bors r-

@ltratt
Copy link
Member

ltratt commented Apr 27, 2022

bors ping

1 similar comment
@ltratt
Copy link
Member

ltratt commented Apr 28, 2022

bors ping

@bors
Copy link

bors bot commented Apr 28, 2022

pong

@ltratt
Copy link
Member

ltratt commented Apr 28, 2022

bors r+

@bors
Copy link

bors bot commented Apr 28, 2022

Build succeeded:

@bors bors bot merged commit c5c7d65 into softdevteam:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants