Fix severe peformance issue accessing keys #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "true" in the call to Generation::create() in OSToken::OSToken() is used as the umask when it's supposed to be the isToken value (softhsm#566). Remove the default value from isToken because it's dangerous and there are only two callers. Explicitly pass "true" and "false" for isToken. Failing to consider this a token generation file means that the value is never refreshed for read-only operations. All objects are reloaded from disk every time one of them is refreshed. List operations take a long time because all of the objects are re-read for each object. Fixes softhsm#680.
|
|
nomis
changed the title
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Oct 31, 2023
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Oct 31, 2023
|
@halderen it looks like you're nearing the point of making a release for other changes, could you merge this soon? |
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Nov 29, 2024
ijsf
approved these changes
Nov 29, 2024
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Nov 29, 2024
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Nov 29, 2024
antoinelochet
pushed a commit
to antoinelochet/SoftHSMv2
that referenced
this pull request
Dec 3, 2024
bjosv
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good!
A fixup for #566.
Maybe there is clang-tidy checker that could have helped us catching this, implicit-bool-conversion might be to broad but maybe there is something else in that toolbox.
jschlyter
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "true" in the call to Generation::create() in OSToken::OSToken() is
used as the umask when it's supposed to be the isToken value (#566).
Remove the default value from isToken because it's dangerous and there are
only two callers. Explicitly pass "true" and "false" for isToken.
Failing to consider this a token generation file means that the value is
never refreshed for read-only operations. All objects are reloaded from
disk every time one of them is refreshed. List operations take a long time
because all of the objects are re-read for each object.
Fixes #680.