Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add RSVP and Chalk to project devDependencies #37

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

sohara
Copy link
Contributor

@sohara sohara commented Dec 17, 2016

It's not necessary for dependencies to be added to a consuming application or addon in order to be used in a given addon. Just need to make sure that the require statements are at the right places.

@notmessenger
Copy link
Collaborator

notmessenger commented Dec 20, 2016

@sohara How do we ensure that that these dependencies (rsvp and chalk) are installed in the user's environment for their requirement in the script? Are they standard packages in Node's installation? Otherwise do they not need to be installed as a dependency?

@sohara
Copy link
Contributor Author

sohara commented Dec 20, 2016

They are already in your addons dependencies list in the package.json:
https://github.com/softlayer/ember-cli-jsdoc/blob/master/package.json#L28-L34

@notmessenger
Copy link
Collaborator

Oh, right, sorry. I meant to remove those when I moved them to the blueprint. I've begun moving dependency management of this sort into the blueprints so that any version differences between multiple addons with the same dependencies can be better managed.

If these did not exist in the dependencies section would you be okay with them being in the blueprint then?

@sohara
Copy link
Contributor Author

sohara commented Dec 20, 2016

Hmm, I'm not personally used to addons handling that concern that way. I mean, if my app's package.json were to have any entry for every dependency of everyaddon that I include, it would get pretty hairy, I think.

I guess what I mean is that as an app developer, I don't want to manage my dependencies' dependencies.

As far as resolving/managing different versions of sub-dependencies used by the same project, I suppose that's something I would be concerned about for code that gets shipped to a client, but less so for build tooling.

@notmessenger
Copy link
Collaborator

The thinking is that you would not have to manage your dependencies dependencies. You would only need to manage the versions of the addons you are using in your app and upgrade those as desired and they will then manage their dependency versions via their blueprint.

@notmessenger notmessenger merged commit b67157a into softlayer:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants