Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved successful response to command - slcli virtual edit #1618

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Improved successful response to command - slcli virtual edit #1618

merged 2 commits into from
Apr 21, 2022

Conversation

edsonarios
Copy link
Contributor

Main Issue: #1616

softlayer-python/ (issue1616-virtual-edit *) $ slcli virtual edit 123--hostname hostnameEdited --tag NewTag --public-speed 10
The hostname of virtual server instance: 123 was updated.
The tags of virtual server instance: 123 was updated.
The public speed of virtual server instance: 123 was updated.

@edsonarios edsonarios self-assigned this Apr 20, 2022
BrianSantivanez
BrianSantivanez approved these changes Apr 20, 2022
View reviewed changes
Copy link

@BrianSantivanez BrianSantivanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff linked an issue Apr 21, 2022 that may be closed by this pull request
Improve responses of the commands #1616
Closed
@allmightyspiff allmightyspiff merged commit 96ec44d into softlayer:master Apr 21, 2022
@edsonarios edsonarios mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSantivanez BrianSantivanez BrianSantivanez approved these changes

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@caberos caberos Awaiting requested review from caberos

Assignees

@edsonarios edsonarios

Labels
New Feature
Projects
No open projects
Q2 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve responses of the commands
3 participants
@edsonarios @allmightyspiff @BrianSantivanez