Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command ipsec order #1698

Merged
merged 4 commits into from
Jul 29, 2022
Merged

New command ipsec order #1698

merged 4 commits into from
Jul 29, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jul 18, 2022

@edsonarios
Copy link
Contributor

Screenshots of the test result
image
image

edsonarios
edsonarios approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff linked an issue Jul 21, 2022 that may be closed by this pull request
New command ipsec order #1696
Closed
allmightyspiff
allmightyspiff requested changes Jul 21, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need a unit test for the new manager function you added, and a confirmation for the order like Brian mentioned. Thanks

SoftLayer/managers/ipsec.py Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit 248a52a into softlayer:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSantivanez BrianSantivanez BrianSantivanez left review comments

@edsonarios edsonarios edsonarios approved these changes

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@caberos caberos

Labels
CLI New Feature
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command ipsec order
4 participants
@caberos @edsonarios @allmightyspiff @BrianSantivanez