New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: has no call signatures #255

Merged

mindhells merged 1 commit into softonic:migrate-to-typescript from yutak23:migrate-to-typescript

Nov 21, 2023

Contributor

yutak23 commented Nov 21, 2023 •

edited

Loading

The problem that occurred previously is occurring again.
I think we should do exports for both esm and cjs.

The same support is available in repositories such as stripe-node.

Details will be as per the PR below.

test

cjs: no error
esm: no error

		"@tsconfig/node16": "^16.1.1",
		"@tsconfig/strictest": "^2.0.2",
		"typescript": "~5.2.2",

{
	"extends": ["@tsconfig/node16/tsconfig.json", "@tsconfig/strictest/tsconfig.json"],
	"compilerOptions": {
		"outDir": "dist",
		"declaration": true,
		"sourceMap": true
	},
	"include": ["srv/**/*.ts"],
	"exclude": ["node_modules", "dist"]
}


fix: has no call signatures

174c516

yutak23 mentioned this pull request

feat: migrate to typescript #253

Merged

mindhells merged commit a22972a into softonic:migrate-to-typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment