Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: body is used without checking the existense of body_path. #71

Closed
perfectmak opened this issue Dec 29, 2020 · 1 comment · Fixed by #85
Closed

Bug: body is used without checking the existense of body_path. #71

perfectmak opened this issue Dec 29, 2020 · 1 comment · Fixed by #85

Comments

@perfectmak
Copy link

Contrary to what is written in the readme:

When providing a body and body_path at the same time, body_path will be attempted first, then falling back on body if the path can not be read from.

The actual javascript code for extracting releaseBody checks if body is provided and ignores reading the body_path outright.
@perfectmak perfectmak changed the title body is used without checking the existense of body_path Bug: body is used without checking the existense of body_path. Dec 29, 2020
@softprops
Copy link
Owner

Thanks for the bug report. If I don't get to this sooner I'll happily accept a pull request

This was referenced Mar 19, 2021
Merged
Closed
softprops pushed a commit that referenced this issue Mar 21, 2021
@yin1999
fix: Get the same behavior described in Docs(#71) (#85)
dac15d3 
Now trying read body path first then falling back on body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #71: Get the same behavior described in Docs
2 participants
@softprops @perfectmak