Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failure #448

Closed
wants to merge 3 commits into from
Closed

fix failure #448

wants to merge 3 commits into from

Conversation

till
Copy link
Contributor

@till till commented May 6, 2024

  • Fix(temp): console.log
  • broken dist
  • Fix: error handling

till added 3 commits May 6, 2024 14:41
@till
Fix(temp): console.log
a966475
@till
broken dist
5ce49bb
@till
Fix: error handling
40bfa17 
- refactored the big `if/else` to exit early
- added error handling for different errors while creating a release
@till
Copy link
Contributor Author

till commented May 6, 2024

I'll try to rebase this (maybe) tomorrow. The last commit does not apply to my previous one for some reason. But it's too late now. I was trying to simplify your code a little bit and add error handling for 403, 404 and 422. Just to make it easier for people to see what's wrong.

@till
Copy link
Contributor Author

till commented May 6, 2024

Replaced by #449

@till till closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessiG2319 JessiG2319 JessiG2319 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@till @JessiG2319