Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preserve upload order #500

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

richarddd
Copy link
Contributor

Fixes: #44

@richarddd
Copy link
Contributor Author

@chenrui333 sorry for the bump but is this something you can take a look at please? 🙂

Copy link
Collaborator

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add a test for it?

@chenrui333
Copy link
Collaborator

Error: [tsl] ERROR in /home/runner/work/action-gh-release/action-gh-release/src/main.ts(91,18)
      TS2339: Property 'preserve_order' does not exist on type 'Config'.

@richarddd
Copy link
Contributor Author

Thanks. Tests should pass now!

@richarddd
Copy link
Contributor Author

@chenrui333 can we merge this please?

@richarddd
Copy link
Contributor Author

@chenrui333 @kbakdev would be great if we can merge and release :)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title Preserve upload order feature: preserve upload order Nov 11, 2024
@chenrui333
Copy link
Collaborator

@richarddd sorry about the delay, and thanks for your first contribution!! 🙏 ❤️

@chenrui333 chenrui333 merged commit d5f028c into softprops:master Nov 11, 2024
1 check passed
@chenrui333 chenrui333 changed the title feature: preserve upload order feat: preserve upload order Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to upload files synchronously, to conserve ordering
3 participants