Support custom target_commitish value #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff30f8e.
|
I wish it be merged |
defunctzombie
added a commit
to foxglove/action-gh-release
that referenced
this pull request
Mar 10, 2021
|
Just ran into this problem after naively assuming it would respect the contextual commitish (e.g. |
|
I've integrated the latest changes from upstream. |
|
Looks good. Thanks for |
|
Please can you release this, too? We're keen to get this change into our projects, rather than looking for an alternative. |
|
@softprops any tentative date for the new release? |
|
Hello! Also would love for the change to be released. |
|
Hi @softprops! It looks like this still isn't released. Please can you release it so we can start using the feature? Thanks! |
softprops
pushed a commit
that referenced
this pull request
Jul 25, 2021
* Make target_commitish configurable * Store compiled action for testing * Add target_commitish to metadata * Allow override of target_commitish for updating * Print commit usage * Improve message for commit usage * Update draft releases too * Revert "Update draft releases too" This reverts commit ff30f8e. * Integrate latest changes from upstream.
softprops
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Make target_commitish configurable * Store compiled action for testing * Add target_commitish to metadata * Allow override of target_commitish for updating * Print commit usage * Improve message for commit usage * Update draft releases too * Revert "Update draft releases too" This reverts commit ff30f8e. * Integrate latest changes from upstream.
softprops
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Make target_commitish configurable * Store compiled action for testing * Add target_commitish to metadata * Allow override of target_commitish for updating * Print commit usage * Improve message for commit usage * Update draft releases too * Revert "Update draft releases too" This reverts commit ff30f8e. * Integrate latest changes from upstream.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new input
target_commitish.By using this input you can provide a custom value for the commit which is used by the GitHub release.
If this value is not provided, GitHub will use the default branch, see the API documentation.
Now it's possible to provide a specific commit if you create a release without a tag:
I've update the existing tests and added a new test for checking the parsing of the configuration.