Add tty detection for MSYS terminals. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should try to get #11 merged first. Once that's done, I'll rebase this PR. :-) |
|
Changes Unknown when pulling 1c423c3 on BurntSushi:mintty into ** on softprops:master**. |
1 similar comment
|
Changes Unknown when pulling 1c423c3 on BurntSushi:mintty into ** on softprops:master**. |
|
@softprops Thanks! If CI passes, then I think this one should be good to go too. :-) FWIW, I realize this implementation is a bit gnarly. I'd be happy to play unofficial maintainer. I'm watching this repo, so I'll keep an eye on it if any bugs crop up. |
1 similar comment
This improves the tty detection in MSYS terminal environments on Windows. Specifically, it uses heuristics to determine whether a standard handle is a pipe or a tty. Behavior in normal Windows consoles remains unchanged. Fixes softprops#10
1 similar comment
|
@softprops Thanks! Sorry to be a bother, but could you also publish a new release too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the tty detection in MSYS terminal environments on
Windows. Specifically, it uses heuristics to determine whether a
standard handle is a pipe or a tty.
Behavior in normal Windows consoles remains unchanged.
Fixes #10