fix test item-not-on-struct-fail's expected stderr to include error code #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really appreciate the extra help on this |
|
Merged the other change if you wanted to rebase I'll merge this |
phrohdoh
force-pushed
the
fix-test_item-not-on-struct-fail_stderr-include-error-code
branch
from
ac79206 to
6966e19
Compare
Rebased! |
phrohdoh
deleted the
fix-test_item-not-on-struct-fail_stderr-include-error-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this sits on top of #150 (to avoid CI failing due to those issues) and if/once that is merged this should be rebased on top of then-mastersuch that this PR contains only relevant commits. Of course if this is wanted without waiting on #150, those commits can be rebased away from this PR's head repo/branch as desired.#150 has been merged and this PR has been rebased on top of the new
master, so this can be merged.What did you implement:
Testing compilation error of
#[derive(Item)]on a non-struct(item-not-on-struct-fail) failed due to missing error code in the expected stderr content, so I've added the code.How did you verify your change: