-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port hyperlocal client to latest hyper #29
Conversation
@danieleades I just merged #25 let me know if that unblocks what you were blocked on for this pull |
tokio has just released a stable release using futures::Stream, instead of futures-preview::Stream. I would expect Hyper to bump it's dependency any day now. Once that happens, this pull request should be updated, or if it is merged, a new pull request should be opened for that update. only then will i be unblocked downstream (otherwise we have a mixture of |
i'm happy this is ready to merge. it's a major change, and a big refactor of the client and uri modules. |
01391da
to
9f32575
Compare
For visibility, hyper has just merged the move to futures, rather than futures-preview. Once this is released, hyperlocal should bump the hyper dependency and move to stable tokio |
hyper has just released. will update this pull request in the next couple of days. |
'server' module has been disabled for now
9f32575
to
b711163
Compare
53c3bfb
to
8c8b7fd
Compare
this is now updated to latest hyper. |
closes #23 |
closes #22 |
ping @softprops |
Sorry for the many delays on this. @danieleades I'll try to commit to going though this but the end of the weekend. |
This looks great! I'm shoot for a release this weekend |
This was required to support porting shiplift to futures 0.3 (softprops/shiplift#191).
I've disabled the server implementation for now, and have ported only the client.