Adding support for waiting on specific job/step completion in turnstyle #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds in support for two new input fields: * job-to-wait-for * step-to-wait-for The idea of these new inputs allows the turnstyle waiter to examin a previous run's jobs->steps and allows for more granular control of what phase of the workflow to wait on. The use case of this is my company currently needs to split our deployment workflow (gitops commit + argocd sync) across two workflows as we want to make sure the gitops commit runs sequentally. Using a turnstyle at the workflow level means that a subsequent sync from argo would delay the next workflow execution until the subsequent job/steps complete. This PR updates the waiter to, if a previous run is found, and the above inputs are set, make subsequent requests to the ghAPI and check to see if the desired job/step is has finished executing
selecsosi
force-pushed
the
selecsosi/add-job-and-step-to-wait-for
branch
from
56f8d08 to
425bf1c
Compare
|
@selecsosi thanks a lot for your efforts on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in support for two new input fields:
The idea of these new inputs allows the turnstyle waiter to examin a previous run's jobs->steps and allows for more granular control of what phase of the workflow to wait on.
The use case of this is my company currently needs to split our deployment workflow (gitops commit + argocd sync) across two workflows as we want to make sure the gitops commit runs sequentally. Using a turnstyle at the workflow level means that a subsequent sync from argo would delay the next workflow execution until the subsequent job/steps complete.
This PR updates the waiter to, if a previous run is found, and the above inputs are set, make subsequent requests to the ghAPI and check to see if the desired job/step is has finished executing