Skip to content

Commit

Permalink
Add editorial checks through Vale (#12)
Browse files Browse the repository at this point in the history
* add vale config

* update existing content based on vale lint checks

* linting

* remove alex from npm deps

* update workflow

* add installation step

* Update poetry.lock

* sync vale before running it in pre-commit

Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>

* lint file

---------

Co-authored-by: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
  • Loading branch information
d33bs and falquaddoomi authored Apr 11, 2024
1 parent f11d11a commit ba0f385
Show file tree
Hide file tree
Showing 11 changed files with 502 additions and 5,144 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/pre-commit-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
- uses: actions/checkout@v4
- name: Install python env
uses: ./.github/actions/install-python-env
- name: Install node env
uses: ./.github/actions/install-node-env
- name: Install vale dependencies
run: |
poetry run vale sync
- uses: pre-commit/action@v3.0.1
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -297,3 +297,6 @@ dist
# almanac-specific ignores

/src/almanac/_build

# for ignoring vale package installs
/styles
14 changes: 4 additions & 10 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,11 @@ repos:
- id: actionlint-docker
- repo: local
hooks:
- id: alex.js
name: alex.js language check
entry: npx alex
- id: vale.sh
name: vale.sh writing checks
entry: poetry run poe vale-checks
language: system
pass_filenames: true
exclude: |
(?x)^(
.*\.lock |
.pre-commit-config.yaml |
src/almanac/_config.yml
)$
pass_filenames: false
- id: cffconvert
name: cffconvert check for citation.cff formatting
entry: poetry run cffconvert --validate
Expand Down
13 changes: 13 additions & 0 deletions .vale.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# generated from https://vale.sh/generator/
StylesPath = styles

MinAlertLevel = warning

Vocab = almanac

Packages = proselint, write-good, alex

[*.{md}]
BasedOnStyles = Vale, proselint, write-good, alex

write-good.TooWordy = NO
Loading

0 comments on commit ba0f385

Please sign in to comment.