Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beginning of time focused chapter #37

Merged
merged 17 commits into from
May 24, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented May 19, 2024

Description

This PR adds the beginning of a time-focused chapter as part of addressing #25 .

Thanks for any thoughts or feedback you may have!

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat; I like the idea of software following a lifecycle, and your metaphors are vivid. I left a question, but otherwise it all looks good to me.

src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see the expanded material! It's coming together nicely! I made a couple comments, but I think its ready to merge

src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
src/almanac/verdant-sundial/verdant-sundial.md Outdated Show resolved Hide resolved
d33bs and others added 3 commits May 24, 2024 13:46
Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
@d33bs
Copy link
Member Author

d33bs commented May 24, 2024

Thanks @falquaddoomi and @gwaybio ! Merging this in after responding to your thoughts and changing things around a bit.

@d33bs d33bs merged commit 822654a into software-gardening:main May 24, 2024
2 checks passed
@d33bs d33bs deleted the start-time branch May 24, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants