Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with cairo-test and cairo-run from Scarb #75

Open
piotmag769 opened this issue Jun 3, 2024 · 0 comments
Open

Integrate with cairo-test and cairo-run from Scarb #75

piotmag769 opened this issue Jun 3, 2024 · 0 comments
Labels
cairo-compiler Requires changes to cairo-compiler. input-format Requires changing the input format (and therefore updating integrated tools).

Comments

@piotmag769
Copy link
Collaborator

We need to learn the mentioned tools to produce an input file for the profiler. Requires adding a specific field was_run_with_header since the heuristic that contracts' entrypoints are run without header is not true for the aforementioned tools
@piotmag769 piotmag769 added cairo-compiler Requires changes to cairo-compiler. snfoundry asap labels Jun 3, 2024
@piotmag769 piotmag769 moved this from Triage to TODO in cairo-profiler Jun 3, 2024
@piotmag769 piotmag769 added input-format Requires changing the input format (and therefore updating integrated tools). and removed scarb labels Jun 3, 2024
This was referenced Jun 7, 2024
Merged
Merged
github-merge-queue bot pushed a commit to foundry-rs/starknet-foundry that referenced this issue Jun 10, 2024
@ddoktorski
Add run_with_call_header field to CallTrace (#2180)
0af6d8b 
<!-- Reference any GitHub issues resolved by this PR -->

Related software-mansion/cairo-profiler#75

## Introduced changes

<!-- A brief description of the changes -->

- Updated profiler related code to align with the changes from
software-mansion/cairo-profiler#92

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [X] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
@piotmag769 piotmag769 removed the asap label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cairo-compiler Requires changes to cairo-compiler. input-format Requires changing the input format (and therefore updating integrated tools).
Projects
cairo-profiler
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddoktorski @piotmag769