Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat syscalls as nodes #112

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Treat syscalls as nodes #112

merged 12 commits into from
Nov 4, 2024

Conversation

THenry14
Copy link
Member

@THenry14 THenry14 commented Oct 14, 2024 •
edited
Loading

Closes #88

Introduced changes

  • Remove syscalls from samples list, and treat them as separate nodes
  • Allow to pass custom resource map with resources cost different to default one

Checklist

  • Linked relevant issue
  • Updated relevant documentation (README.md)
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

Minimal example:
obraz

piotmag769
piotmag769 reviewed Oct 14, 2024
View reviewed changes
crates/cairo-profiler/resources/versioned_constants_0_13_2_1.json Show resolved Hide resolved
crates/cairo-profiler/src/main.rs Show resolved Hide resolved
crates/cairo-profiler/src/main.rs Outdated Show resolved Hide resolved
crates/trace-data/src/lib.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/syscall.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/main.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/resources/versioned_constants_0_13_2_1.json Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/syscall.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it doesn't mess up the inlining? It shouldn't since the syscalls are always leaves in the tree, but it's worth verifying

crates/cairo-profiler/src/main.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/trace-data/src/lib.rs Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/sample.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
@THenry14 THenry14 force-pushed the szymczyk/88-syscalls-as-nodes branch from c690afe to 1086f92 Compare October 25, 2024 13:43
THenry14
THenry14 commented Oct 25, 2024
View reviewed changes
Copy link
Member Author

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it doesn't mess up the inlining? It shouldn't since the syscalls are always leaves in the tree, but it's worth verifying

Yup, when I was testing I did it for both inlining and non-inlining, and compared to the same artifacts using code from main, nothing looked out of place or suspicious

crates/cairo-profiler/src/main.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/sample.rs Show resolved Hide resolved
crates/trace-data/src/lib.rs Show resolved Hide resolved
@THenry14
Copy link
Member Author

I am aware the review increased in size notably, sorry for that (also I tend to put review changes into one commit, which now I realized may be a pain to review in such big reviews). Please let me know if you want me to split it to smaller ones. sorry.

piotmag769
piotmag769 reviewed Oct 28, 2024
View reviewed changes
crates/cairo-profiler/src/versioned_constants_reader.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/syscall_trace.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/syscall_trace.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/syscall_trace.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
@THenry14 THenry14 force-pushed the szymczyk/88-syscalls-as-nodes branch from bdee013 to 67ed200 Compare October 30, 2024 09:41
piotmag769
piotmag769 reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM logic wise, just nitpicks. Really good job!

Cargo.toml Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/versioned_constants_reader.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/stack_trace.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/sample.rs Show resolved Hide resolved
@THenry14 THenry14 mentioned this pull request Oct 30, 2024
Open
@THenry14 THenry14 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 58c852e Nov 4, 2024
4 checks passed
@THenry14 THenry14 deleted the szymczyk/88-syscalls-as-nodes branch November 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syscalls as nodes in trace tree
2 participants
@THenry14 @piotmag769